Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: Annotation cache usage docs #967

Merged
merged 4 commits into from
Mar 16, 2023
Merged

ADD: Annotation cache usage docs #967

merged 4 commits into from
Mar 16, 2023

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

FriederikeHanssen
FriederikeHanssen reviewed Mar 16, 2023
View reviewed changes
conf/modules/prepare_cache.config
mode: params.publish_dir_mode,
path: { "${params.outdir}/cache/" }
mode: params.publish_dir_mode,
path: { params.outdir_cache ? "${params.outdir_cache}/": "${params.outdir}/cache/" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is trippy read :D

FriederikeHanssen
FriederikeHanssen reviewed Mar 16, 2023
View reviewed changes
docs/usage.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 16, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 4221d5d

+| ✅ 152 tests passed       |+
#| ❔   8 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-03-16 17:16:06

@maxulysse @FriederikeHanssen
Apply suggestions from code review
2448bc0 
Co-authored-by: FriederikeHanssen <Friederike.hanssen@qbic.uni-tuebingen.de>
maxulysse
maxulysse commented Mar 16, 2023
View reviewed changes
docs/usage.md Outdated Show resolved Hide resolved
@maxulysse maxulysse merged commit 3b5f2a4 into nf-core:dev Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @FriederikeHanssen