Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated ascat for reproducibility #988

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Updated ascat for reproducibility #988

merged 3 commits into from
Apr 5, 2023

Conversation

SusiJo
Copy link
Contributor

@SusiJo SusiJo commented Apr 5, 2023 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@SusiJo SusiJo requested a review from maxulysse as a code owner April 5, 2023 12:18
@github-actions
Copy link

github-actions bot commented Apr 5, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit e5b0b48

+| ✅ 151 tests passed       |+
#| ❔   9 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-04-05 12:21:39

FriederikeHanssen
FriederikeHanssen approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you ❤️

@SusiJo SusiJo merged commit d513738 into nf-core:dev Apr 5, 2023
@SusiJo SusiJo linked an issue Apr 5, 2023 that may be closed by this pull request
Output from ascat not stable #702
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@maxulysse maxulysse Awaiting requested review from maxulysse maxulysse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output from ascat not stable
2 participants
@SusiJo @FriederikeHanssen