Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 952 #998

Merged
merged 10 commits into from
Apr 14, 2023
Merged

Issue 952 #998

merged 10 commits into from
Apr 14, 2023

Conversation

FriederikeHanssen
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen commented Apr 13, 2023 •
edited
Loading

Close #952

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@FriederikeHanssen FriederikeHanssen marked this pull request as draft April 13, 2023 15:50
@github-actions
Copy link

github-actions bot commented Apr 13, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 1bb57d1

+| ✅ 151 tests passed       |+
#| ❔   9 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-04-14 12:54:19

@FriederikeHanssen FriederikeHanssen marked this pull request as ready for review April 13, 2023 16:05
@FriederikeHanssen FriederikeHanssen linked an issue Apr 13, 2023 that may be closed by this pull request
Parallelisation of variant call across regions causes Manta to miss some variant classes #952
Closed
maxulysse
maxulysse reviewed Apr 13, 2023
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@FriederikeHanssen @maxulysse
Update subworkflows/local/bam_variant_calling_germline_manta/main.nf
1bb57d1 
Co-authored-by: Maxime U Garcia <maxime.garcia@scilifelab.se>
@maxulysse maxulysse merged commit 9f3ff50 into nf-core:dev Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parallelisation of variant call across regions causes Manta to miss some variant classes
2 participants
@FriederikeHanssen @maxulysse