Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tests with nf-test #91

Closed
grst opened this issue Jan 31, 2022 · 9 comments · Fixed by #291
Closed

Implement tests with nf-test #91

grst opened this issue Jan 31, 2022 · 9 comments · Fixed by #291
Assignees
Labels
enhancement New feature or request quality & consistency improve quality and reduce maintenance burden

Comments

@grst
Copy link
Member

grst commented Jan 31, 2022

Pytest workflow makes it easier to maintain larger test suites and also allows to check outputs.

cf. nf-core/tools#605, nf-core/rnaseq#546, https://github.com/nf-core/sarek/tree/dev/tests

Testing scenarios:

  • Run pipeline with more than one file
  • different parameter combinations
  • different filenames and folder structures for cellranger
  • run subworkflows with and without index
  • different protocols, if we manage to get the test files
@grst grst added the enhancement New feature or request label Jan 31, 2022
@grst grst changed the title Implement tests with pytest-workflow Implement tests with nf-test Jun 27, 2023
@grst
Copy link
Member Author

grst commented Jan 18, 2024

I'm pretty sure the latest bugs in 2.5.0 would have been caught by that.

@fmalmeida, do you already have something in the internal pipeline that you could upstream here?

@fmalmeida
Copy link
Contributor

Yes,
We have some internal nf-tests that we can start merging it here, adapting it to check only the public modules.

@fmalmeida fmalmeida self-assigned this Jan 18, 2024
@fmalmeida
Copy link
Contributor

Is there a nf-core pipeline already standardized with nf-test so that I can "copy" the same standards in terms of organization and setup?

@grst
Copy link
Member Author

grst commented Jan 18, 2024

e.g. https://github.com/nf-core/ampliseq/tree/dev or https://github.com/nf-core/spatialtranscriptomics, but not sure if this qualifies as "standardized".

Modules can since very recently be tested with nf-test in nf-core/modules. There's even documentation for that https://nf-co.re/docs/contributing/modules#writing-nf-test-tests

@grst grst added the quality & consistency improve quality and reduce maintenance burden label Jan 18, 2024
@fmalmeida
Copy link
Contributor

Hi @grst ,
Added the first one, for alevin aligner.
If you can take a look at that one already while I add the others, just to see if there is anything very clear that should be done different or it is fine as is.
😄

@grst
Copy link
Member Author

grst commented Jan 19, 2024

Is there a PR I can look at 👀?

@fmalmeida
Copy link
Contributor

Did not open, is still in the branch (shown in the right menu)

I can open a draft if you prefer.

@grst grst mentioned this issue Jan 19, 2024
11 tasks
@grst
Copy link
Member Author

grst commented Jan 19, 2024

I see, thanks! I opened one now, makes it easier to discuss...

@fmalmeida fmalmeida linked a pull request Feb 14, 2024 that will close this issue
11 tasks
@fmalmeida
Copy link
Contributor

Hello hello,
This was merged/solved by #291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quality & consistency improve quality and reduce maintenance burden
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants