Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create TEMPLATE branch #17

Closed
lpantano opened this issue Jun 20, 2019 · 4 comments
Closed

create TEMPLATE branch #17

lpantano opened this issue Jun 20, 2019 · 4 comments

Comments

@lpantano
Copy link
Contributor

hi,

This is the template I have in my branch done with nf-core 1.6. Should I just push the TEMPLATE branch to the smrnaseq pipeline since there is no branch right now?

https://github.com/lpantano/smrnaseq/tree/TEMPLATE

@apeltzer
Copy link
Member

Yes! You could do that, to get this going! Thanks a bunch for working on this!

@lpantano
Copy link
Contributor Author

@drpatelh
Copy link
Member

Based on what it says here: https://nf-co.re/developers/sync
"Follow the prompts to fill in the pipeline name, description and author(s). Make sure that you take the exact text that you already have already used in your pipeline's nextflow.config file (manifest.name etc.), if these have already been written."

In nextflow.config, the manifest.author and manifest.description fields arent the same in the TEMPLATE and dev branches at the moment. Im assuming that will matter when the pipeline is auto-created by the template-bot?

Maybe the easiest thing to do is to create a PR to the TEMPLATE branch and make those fields the same?

From the last few PRs it seems like the pipeline is working @lpantano ? Im just thinking it may be worth doing another PR after that from dev to master to update all of the all code with the new template.

@drpatelh
Copy link
Member

I believe you have done this now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants