Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix manifest information #18

Merged
merged 3 commits into from
Jul 8, 2019
Merged

fix manifest information #18

merged 3 commits into from
Jul 8, 2019

Conversation

lpantano
Copy link
Contributor

fixing manifest to match dev

#17

@drpatelh is that what you meant?

@drpatelh
Copy link
Member

@lpantano Exactly! To be honest, Im not sure how much it matters but as its mentioned in the docs its best to be safe than sorry.

@drpatelh
Copy link
Member

Travis CI is failing for a number of weird and wonderful reasons. The markdownlint error will be the easiest to fix.

I havent seen those linting errors before @sven1103 @apeltzer is this expected because the tests are running on the TEMPLATE branch? Im assuming they werent set up for this purpose. Do we need to integrate this into tools somehow?

The pipeline failure is down to that weird behaviour @apeltzer noticed yesterday which will probably just require a re-trigger when things are working again.

@drpatelh
Copy link
Member

@lpantano Those weird Travis errors are back with a vengeance. I wonder if thats why the linting is not running as expected. We may have to wait until things are working again to re-trigger and see...

@drpatelh drpatelh mentioned this pull request Jul 5, 2019
@lpantano
Copy link
Contributor Author

lpantano commented Jul 8, 2019

@drpatelh , I think is ok now. The travis is passing, although I don't know why is not updating here. If the manifest seems ok to you, I can merge it.

@drpatelh
Copy link
Member

drpatelh commented Jul 8, 2019

Yep. Im happy if you are. Hopefully, you should be able to merge yourself now 👍

@lpantano lpantano merged commit 03d3d90 into nf-core:TEMPLATE Jul 8, 2019
@lpantano lpantano deleted the TEMPLATE branch July 8, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants