Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change Trimgalore max_length parameter #77

Closed
DwinGrashof opened this issue Apr 19, 2021 · 1 comment · Fixed by #81
Closed

Cannot change Trimgalore max_length parameter #77

DwinGrashof opened this issue Apr 19, 2021 · 1 comment · Fixed by #81
Assignees
Milestone

Comments

@DwinGrashof
Copy link

When investigating other smallRNAs one might want to increase the max_length of trimgalore, so that reads > 40bp are not thrown out. However, this is not possible in the current 1.,0.0 version of the smrnaseq pipeline. In the main.nf script the max_length is hardcoded as 40 bp into the script, making it impossible to change this parameter.

I changed the hardcoded bit of trimgalore, and added a parameter that can be assigned in the config file, trying to mimic the syntax and style of the min_length parameter. Please mind that there is no "default" in the adapted script. This could very well be added as 40 bp in the future so people won't experience changes when rerunning the pipeline.

I have trouble with creating a branch/PR, so if one of the devs could help me with that, that would be amazing.

@KevinMenden
Copy link
Contributor

Thanks for reporting @DwinGrashof , I'll have a look at it! 👍

@KevinMenden KevinMenden self-assigned this May 6, 2021
@KevinMenden KevinMenden added this to the v1.1.0 milestone May 7, 2021
@KevinMenden KevinMenden linked a pull request May 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants