Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve a few issues #81

Merged
merged 4 commits into from
May 7, 2021
Merged

Solve a few issues #81

merged 4 commits into from
May 7, 2021

Conversation

KevinMenden
Copy link
Contributor

Addresses a few small issues:

  • makes choosing a mirtrace protocol more flexible
  • adds parameter for trim_galore max-length
  • better and flexible memory usage of the mirtrace process

Fixes #68 , #80 , #77

This was linked to issues May 7, 2021
Not possible to use custom trimming profile #80
Closed
Cannot change Trimgalore max_length parameter #77
Closed
mirtrace tries to allocate half of the installed RAM #68
Closed
ggabernet
ggabernet approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@KevinMenden KevinMenden merged commit 976bb3e into nf-core:dev May 7, 2021
@KevinMenden
Copy link
Contributor Author

Thanks @ggabernet , totally forgot to ping you but you reviewed anyway 😁 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggabernet ggabernet ggabernet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@KevinMenden @ggabernet