Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zenodo link and update changelog #150

Merged
merged 1 commit into from
May 18, 2022
Merged

Fix zenodo link and update changelog #150

merged 1 commit into from
May 18, 2022

Conversation

JoseEspinosa
Copy link
Member

In the last template merge (#148) the link to zenodo was broken, fixed here and also updated changelog

@JoseEspinosa JoseEspinosa requested a review from apeltzer May 17, 2022 15:39
@github-actions
Copy link

github-actions bot commented May 17, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 6c97c78

+| ✅ 143 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '2.0.0'
  • readme - README did not have a Nextflow minimum version badge.
  • pipeline_todos - TODO string in README.md: Write a 1-2 sentence summary of what data the pipeline is for and what it does
  • pipeline_todos - TODO string in README.md: Add full-sized test dataset and amend the paragraph below if applicable

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-05-17 15:40:14

apeltzer
apeltzer approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, didn#t check the URL obviously, but should be fine now :-)

@JoseEspinosa JoseEspinosa merged commit 28208c4 into nf-core:dev May 18, 2022
@JoseEspinosa JoseEspinosa deleted the fix_zenodo_link branch May 18, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoseEspinosa @apeltzer