Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Skip_qc not being used #208 #210

Merged
merged 4 commits into from
Feb 17, 2023
Merged

[FIX] Skip_qc not being used #208 #210

merged 4 commits into from
Feb 17, 2023

Conversation

apeltzer
Copy link
Member

@apeltzer apeltzer commented Dec 2, 2022

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@apeltzer apeltzer mentioned this pull request Dec 2, 2022
Closed
@apeltzer apeltzer self-assigned this Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit e7db15f

+| ✅ 158 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-02-17 22:01:23

@apeltzer apeltzer changed the title FIXES 208 Fix skip_qc not being used #208 Dec 2, 2022
@apeltzer apeltzer changed the title Fix skip_qc not being used #208 [FIX] Skip_qc not being used #208 Dec 2, 2022
@apeltzer apeltzer added this to the Release 2.1.1 Patch milestone Dec 2, 2022
@github-actions
Copy link

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

1 similar comment
@github-actions
Copy link

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@apeltzer apeltzer changed the base branch from dev to fix-201 February 17, 2023 21:59
@apeltzer apeltzer marked this pull request as ready for review February 17, 2023 21:59
@apeltzer
Copy link
Member Author

@nf-core-bot fix linting

@apeltzer apeltzer merged commit aa7ea9a into fix-201 Feb 17, 2023
@apeltzer apeltzer deleted the fix-208-skip-qc branch February 17, 2023 22:00
nschcolnicov pushed a commit that referenced this pull request Oct 10, 2024
@atrigila
Merge pull request #210 from atrigila/add_checkqc_2
38d3d0d 
Add option to run checkqc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@apeltzer apeltzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@apeltzer