Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline update / Manual template merge #55

Merged
merged 16 commits into from
Nov 10, 2020
Merged

Conversation

ewels
Copy link
Member

@ewels ewels commented Nov 6, 2020

  • Manually merged the three new template updates and fixed all merge conflicts.
  • Moved all parameter documentation into new nextflow_schema.json file.
  • Renamed --reads to --input to match new nf-core guidelines.
  • Updated CamelCase and Upper Case parameters to be lower_case_snake_case
  • Changed dev version from 1.0.1 to 1.1 as now has fairly major changes.

PR checklist

  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

@ewels ewels requested a review from lpantano November 6, 2020 23:47
@ewels
Copy link
Member Author

ewels commented Nov 6, 2020

Merging this PR should auto-merge / close #51 without needing any additional actions.

@ewels ewels requested a review from a team November 6, 2020 23:56
@ewels

This comment has been minimized.

@ewels

This comment has been minimized.

@ewels ewels added the WIP Work in progress label Nov 7, 2020
@ewels ewels mentioned this pull request Nov 7, 2020
@ewels ewels linked an issue Nov 7, 2020 that may be closed by this pull request
@ewels ewels removed the WIP Work in progress label Nov 7, 2020
@ewels
Copy link
Member Author

ewels commented Nov 7, 2020

Ok, I think that this PR is good to go now 🚀

Tests should all be passing, no additional content to update before merge that I'm aware of ✅

Just need a 👍🏻 review and merge.

@ewels ewels merged commit b7ed1e2 into nf-core:dev Nov 10, 2020
@ewels ewels deleted the template-merge branch November 10, 2020 15:28
nschcolnicov pushed a commit that referenced this pull request Oct 10, 2024
Important! Template update for nf-core/tools v2.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User provided --three_prime_adapter is not recognised
3 participants