Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate parameters #59

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Remove duplicate parameters #59

merged 2 commits into from
Dec 10, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Nov 24, 2020

Removed duplicate mature and hairpin parameters from nextflow.config

These are properly initialised to their default values a few lines down in the same file.

PR checklist

  • This comment contains a description of changes (with reason)

Removed duplicate `mature` and `hairpin` parameters from `nextflow.config`
@lpantano
Copy link
Contributor

it is the lint error expected? otherwise good to me.

@ewels
Copy link
Member Author

ewels commented Nov 24, 2020

ah, the lint error is because v1.12 of tools came out and we need to update: #58

@ewels
Copy link
Member Author

ewels commented Dec 10, 2020

Merging now as I think this PR is good, can take the failing lint tests / template update in a separate PR 👍🏻

@ewels ewels merged commit 1c691ea into dev Dec 10, 2020
@ewels ewels deleted the remove-dup-params branch December 10, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants