-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simplify csv files #263
Conversation
(works locally so far on my progress in nf-core/sarek#379) |
Why are you removing gender information? It is needed for copy number calling |
I actually just remove it from the normal only samples. So far, in previous sarek versions, we had one function to extract information from the TSV file for each step. Basically my plan is to change as little as possible for users like (so switching from TSV to CSV(+header)). |
Ah ok, I see. That makes sense. In the case of providing normal/tumor sample pairs, if the field is left empty, it will set it to 'NA' for both, right and CNV will be skipped? |
That's it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes after our discussion in slack: I get what you mean. For everyone still wanting to provide all columns not much changes except tsv -> csv. The only processes needing the gender information are CNV processes anyway. and for the CNV on germline samples not even the csv parsing code would need to be changed, but we would need to catch somewhere whether CNV tools are specified without gender information
Trying something different with the samplesheet.csv files