Move docker.registry definition out of docker profile #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxulysse
reviewed
May 11, 2023
maxulysse
approved these changes
May 11, 2023
Codecov Report
@@ Coverage Diff @@
## dev #2286 +/- ##
=======================================
Coverage 73.12% 73.12%
=======================================
Files 77 77
Lines 8433 8433
=======================================
Hits 6167 6167
Misses 2266 2266 |
This was referenced May 12, 2023
|
forgot CHANGELOG ;-) |
This was referenced May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
docker.registryconfiguration should always be set, as running on cloud executors will need to pull docker images but will not necessarily use thedockerprofile.