Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync - recognise existing PRs and treat as success #710

Closed
ewels opened this issue Jul 30, 2020 · 2 comments
Closed

Sync - recognise existing PRs and treat as success #710

ewels opened this issue Jul 30, 2020 · 2 comments
Assignees
Milestone

Comments

@ewels
Copy link
Member

ewels commented Jul 30, 2020

See #709 (comment)

Need to catch the following error:

ERROR     Sync failed for nf-core/ampliseq:                          sync.py:385
GitHub API returned code 422:
{
    "message": "Validation Failed",
    "errors": [
        {
            "resource": "PullRequest",
            "code": "custom",
            "message": "A pull request already exists for nf-core:TEMPLATE."
        }
    ],
    "documentation_url": "https://developer.github.com/v3/pulls/#create-a-pull-request"
}

and treat it as a success - in this scenario the PR to update the template already exists, and our new commit is appended to it.

@ewels ewels added this to the 1.10.2 patch milestone Jul 30, 2020
@ewels ewels self-assigned this Jul 30, 2020
@ewels ewels mentioned this issue Jul 30, 2020
6 tasks
@ewels
Copy link
Member Author

ewels commented Jul 30, 2020

Ooh, even better - bioconda bot recognises this and then renames the PR title:

For example: bioconda/bioconda-recipes#23469

ewels added a commit to ewels/nf-core-tools that referenced this issue Jul 31, 2020
@ewels ewels mentioned this issue Jul 31, 2020
6 tasks
@ewels
Copy link
Member Author

ewels commented Jul 31, 2020

Closed in #716

@ewels ewels closed this as completed Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant