Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --ignore option #1150

Closed

Conversation

KevinMenden
Copy link
Contributor

Add the --ignore, -i option to nf-core modules bump-versions to allow ignoring certain modules when bumping software versions.

It's not a blacklist, but it also serves to fix #1142

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #1150 (9622112) into dev (5e9e33c) will increase coverage by 0.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1150      +/-   ##
==========================================
+ Coverage   69.22%   69.27%   +0.04%     
==========================================
  Files          50       50              
  Lines        5232     5247      +15     
==========================================
+ Hits         3622     3635      +13     
- Misses       1610     1612       +2     
Impacted Files Coverage Δ
nf_core/__main__.py 57.02% <66.66%> (+0.11%) ⬆️
nf_core/modules/bump_versions.py 80.00% <86.66%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9e33c...9622112. Read the comment docs.

Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nf_core/modules/bump_versions.py Outdated Show resolved Hide resolved
KevinMenden and others added 2 commits July 5, 2021 10:08
Co-authored-by: Erik Danielsson <53212377+ErikDanielsson@users.noreply.github.com>
@KevinMenden
Copy link
Contributor Author

Closing in favour of #1164

@KevinMenden KevinMenden closed this Jul 8, 2021
@KevinMenden KevinMenden deleted the bump-versions-ignore-modules branch July 8, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants