Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for blacklist #1162

Merged
merged 11 commits into from
Jul 8, 2021
Merged

Conversation

KevinMenden
Copy link
Contributor

Added support for a configuration file/ blacklist for the nf-core modules bump-versions command.

This is a .yml file which can be filled with module names. The module is completely ignored if False is given:

e.g.
star/align: False

If a version is given, the module is updated/downgrade to that version (if it's different):

star/align: "some version"

So you can either set it to False or to a specific version.

Fixes #1142

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@KevinMenden KevinMenden linked an issue Jul 6, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #1162 (e3b4490) into dev (b6542c8) will increase coverage by 0.03%.
The diff coverage is 77.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1162      +/-   ##
==========================================
+ Coverage   70.58%   70.61%   +0.03%     
==========================================
  Files          48       48              
  Lines        5116     5139      +23     
==========================================
+ Hits         3611     3629      +18     
- Misses       1505     1510       +5     
Impacted Files Coverage Δ
nf_core/modules/nfcore_module.py 96.00% <66.66%> (-4.00%) ⬇️
nf_core/modules/bump_versions.py 79.54% <73.46%> (+0.02%) ⬆️
nf_core/utils.py 83.84% <88.23%> (+0.20%) ⬆️
nf_core/lint/__init__.py 74.13% <100.00%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6542c8...e3b4490. Read the comment docs.

@KevinMenden KevinMenden added the WIP Work in progress label Jul 7, 2021
@KevinMenden KevinMenden added ready-for-review and removed WIP Work in progress labels Jul 8, 2021
Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just a few small suggestions

nf_core/modules/bump_versions.py Outdated Show resolved Hide resolved
nf_core/modules/bump_versions.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Erik Danielsson <53212377+ErikDanielsson@users.noreply.github.com>
@KevinMenden
Copy link
Contributor Author

Thanks, good suggestions 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add blacklist to modules bump-versions
2 participants