Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules refactoring #1171

Merged
merged 37 commits into from
Jul 8, 2021
Merged

Modules refactoring #1171

merged 37 commits into from
Jul 8, 2021

Conversation

KevinMenden
Copy link
Contributor

This PR combines all of the changes that were necessary to adapt the code to the new structure of nf-core/modules and nf-core pipelines.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

KevinMenden and others added 30 commits July 7, 2021 14:28
…cture

Adapt `modules install` to new directory structure
Adjust `modules lint` to new directory structure
Updated `modules remove` and `modules list` for restructuring
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #1171 (7c8f113) into dev (004b2dd) will decrease coverage by 0.87%.
The diff coverage is 65.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1171      +/-   ##
==========================================
- Coverage   71.56%   70.68%   -0.88%     
==========================================
  Files          29       48      +19     
  Lines        3355     5107    +1752     
==========================================
+ Hits         2401     3610    +1209     
- Misses        954     1497     +543     
Impacted Files Coverage Δ
nf_core/licences.py 25.00% <0.00%> (-61.74%) ⬇️
nf_core/lint/actions_schema_validation.py 90.62% <ø> (ø)
nf_core/sync.py 51.79% <30.76%> (-0.70%) ⬇️
nf_core/launch.py 64.93% <42.50%> (-2.10%) ⬇️
nf_core/__main__.py 56.91% <43.03%> (-7.28%) ⬇️
nf_core/modules/module_utils.py 44.52% <44.52%> (ø)
nf_core/modules/test_yml_builder.py 45.98% <45.98%> (ø)
nf_core/download.py 54.98% <46.47%> (-9.79%) ⬇️
nf_core/modules/install.py 49.57% <49.57%> (ø)
nf_core/list.py 80.65% <54.16%> (-1.65%) ⬇️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b8a3ed...7c8f113. Read the comment docs.

@KevinMenden KevinMenden linked an issue Jul 8, 2021 that may be closed by this pull request
tests/modules/lint.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay looks good from my side, just two changes for the code I added

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2021

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general to me!

CHANGELOG.md Outdated Show resolved Hide resolved
nf_core/pipeline-template/modules.json Outdated Show resolved Hide resolved
ErikDanielsson and others added 2 commits July 8, 2021 10:06
Co-authored-by: Erik Danielsson <53212377+ErikDanielsson@users.noreply.github.com>
@KevinMenden
Copy link
Contributor Author

Nice, thanks! Now all we need to is to make black happy and then we can merge this beast 😅

@KevinMenden KevinMenden merged commit 32b067a into dev Jul 8, 2021
@KevinMenden KevinMenden deleted the modules-refactoring branch July 8, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update of nf-core/modules file structure
2 participants