-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
obtain module suggestions from installed modules #1624
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1624 +/- ##
==========================================
+ Coverage 64.68% 64.78% +0.09%
==========================================
Files 55 55
Lines 6338 6353 +15
==========================================
+ Hits 4100 4116 +16
+ Misses 2238 2237 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mirpedrol This already looks quite nice, but there are a few things that require some more attention.
Aside from the other comments, there should probably be a test to check if the local modules are collected. Such a test would have caught that all_local_modules
was assigned, but not used.
Co-authored-by: Erik Danielsson <53212377+ErikDanielsson@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, and I've made some comments on things that I think should change.
I don't think we should address this in this PR, but we need to think about if we want the --base-path
flag to work when running modules commands on local custom modules repos. This would mean that one could specify in which directory the modules are located. We might be overloading the option a bit too much then, but since we are already doing that with the commands it might make sense.
Co-authored-by: Erik Danielsson <53212377+ErikDanielsson@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Close #1615
When
nf-core modules test
is run without specifying a module name, the suggestions from the prompt are obtained from the installed modules (instead of nf-core/modules repository).PR checklist
CHANGELOG.md
is updated