Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI testing for GitLab #1665

Merged
merged 14 commits into from
Jul 11, 2022
Merged

Conversation

ErikDanielsson
Copy link
Contributor

Added both pytests and command line tests of the --git-remote option with the nf-core/modules-test repository. Will close #1646.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ErikDanielsson ErikDanielsson linked an issue Jul 8, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #1665 (e2c11b5) into dev (cbe5b2a) will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1665      +/-   ##
==========================================
+ Coverage   64.43%   64.58%   +0.15%     
==========================================
  Files          56       56              
  Lines        6574     6574              
==========================================
+ Hits         4236     4246      +10     
+ Misses       2338     2328      -10     
Impacted Files Coverage Δ
nf_core/modules/install.py 70.51% <0.00%> (+1.28%) ⬆️
nf_core/modules/modules_json.py 32.15% <0.00%> (+1.41%) ⬆️
nf_core/modules/modules_repo.py 80.26% <0.00%> (+3.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe5b2a...e2c11b5. Read the comment docs.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ErikDanielsson
Copy link
Contributor Author

Thanks (:

@ErikDanielsson ErikDanielsson merged commit 92ef6ea into nf-core:dev Jul 11, 2022
@ErikDanielsson ErikDanielsson deleted the gitlab-ci branch July 26, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitLab CI tests for modules
2 participants