Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on package mock #1696

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Conversation

fabianegli
Copy link
Contributor

@fabianegli fabianegli commented Jul 22, 2022

The mock package is now part of the standard library of Python integrated into unittest. The mock package itself is not (regularly) updated any more. See https://pypi.org/project/mock/ (the latest release as of writing has been in 2020).

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #1696 (bbcceeb) into dev (cc1ab61) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1696      +/-   ##
==========================================
- Coverage   67.99%   67.98%   -0.02%     
==========================================
  Files          56       56              
  Lines        6609     6694      +85     
==========================================
+ Hits         4494     4551      +57     
- Misses       2115     2143      +28     
Impacted Files Coverage Δ
nf_core/lint/multiqc_config.py 66.66% <0.00%> (-14.59%) ⬇️
nf_core/lint/actions_awsfulltest.py 83.33% <0.00%> (-5.56%) ⬇️
nf_core/lint/readme.py 75.75% <0.00%> (-4.89%) ⬇️
nf_core/lint/actions_awstest.py 78.94% <0.00%> (-4.39%) ⬇️
nf_core/lint/actions_ci.py 85.48% <0.00%> (-3.61%) ⬇️
nf_core/utils.py 77.46% <0.00%> (-2.66%) ⬇️
nf_core/lint/__init__.py 74.07% <0.00%> (-1.56%) ⬇️
nf_core/schema.py 75.88% <0.00%> (-1.51%) ⬇️
nf_core/launch.py 63.93% <0.00%> (-0.41%) ⬇️
nf_core/modules/install.py 72.72% <0.00%> (-0.35%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc1ab61...bbcceeb. Read the comment docs.

Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fabianegli fabianegli merged commit ca4bd32 into nf-core:dev Jul 22, 2022
@fabianegli fabianegli deleted the use-unittet-mock branch August 16, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants