-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken link in nf-core modules info
#1745
Conversation
This PR is against the
|
Codecov Report
@@ Coverage Diff @@
## dev #1745 +/- ##
==========================================
- Coverage 68.45% 68.44% -0.01%
==========================================
Files 59 59
Lines 7136 7137 +1
==========================================
Hits 4885 4885
- Misses 2251 2252 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Haven't tested it, but reading the code looks good 🚀 |
Close #1736
Don't add the prefix
https://github.com
to the link created by nf-core modules info. Make the link clickable ifself.remote_location
starts by 'http'The command was also failing when there wasn't any module installed from a remote repository. I added the attribute
self.local
to ensure that we only try to obtain information from a local module if it is locally installed.PR checklist
CHANGELOG.md
is updateddocs
is updated