-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only check pipeline name without dashes if the name is provided by prompt #2123
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2123 +/- ##
==========================================
- Coverage 71.42% 71.41% -0.01%
==========================================
Files 77 77
Lines 8356 8358 +2
==========================================
+ Hits 5968 5969 +1
- Misses 2388 2389 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@nvnieuwk would be good if you could test this with your pipeline 🙂 |
It seems to work!
|
Related to #2117 and slack discussion
The code will check that the pipeline name doesn't contain dashes if the name if provided by prompt. With
nf-core create
ornf-core create --name my-name
.It won't be checked if the pipeline name is provided with a template
nf-core create -t template.yml
wheretemplate.yml
contains:If
template.yml
doesn't provide a custom prefix or the prefix is set tonf-core
, dashes won't be allowed.To sync a pipeline created with dashes, the template must be used:
nf-core sync -t template.yml
PR checklist
CHANGELOG.md
is updateddocs
is updated