Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aws_tower profile #2287

Merged
merged 2 commits into from
May 11, 2023
Merged

Remove aws_tower profile #2287

merged 2 commits into from
May 11, 2023

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@maxulysse maxulysse mentioned this pull request May 11, 2023
Merged
9 tasks
@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Merging #2287 (14d4b2e) into dev (90596b9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2287   +/-   ##
=======================================
  Coverage   73.12%   73.12%           
=======================================
  Files          77       77           
  Lines        8433     8433           
=======================================
  Hits         6167     6167           
  Misses       2266     2266

drpatelh
drpatelh approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drpatelh drpatelh merged commit 3ed658f into dev May 11, 2023
@drpatelh drpatelh deleted the remove-aws_tower-profile branch May 11, 2023 17:54
@drpatelh
Copy link
Member

Forgot CHANGELOG 😬

@maxulysse maxulysse mentioned this pull request May 12, 2023
Merged
4 tasks
@mirpedrol mirpedrol mentioned this pull request Jun 28, 2023
Merged
9 tasks
@mirpedrol mirpedrol mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @drpatelh