-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a subcommand to generate a nf-params.yml
template
#2362
Add a subcommand to generate a nf-params.yml
template
#2362
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2362 +/- ##
==========================================
+ Coverage 72.81% 73.17% +0.36%
==========================================
Files 78 79 +1
Lines 8891 9026 +135
==========================================
+ Hits 6474 6605 +131
- Misses 2417 2421 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice, thank you @fbdtemme! 🎉
Just chatting with @mashehu and @mirpedrol about an alternative command name, as we try to reserve the word "template".. I'll let them comment about that though.
Very nice new feature, thanks for contributing! What do you think about |
Yeah, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nice, thanks!
Remember to update the CHANGELOG.md
b54ce92
to
ce3ca4c
Compare
CHANGELOG is updated now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I had now time to play with it:
|
The version is now printed along with the pipeline name. |
Is there anything preventing this PR from being merged? |
Looks like some tests are failing now. Once they are fixed, sound ok to me to merge, do you have permissions? |
Co-authored-by: Phil Ewels <phil.ewels@seqera.io>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
66ce71f
to
aa88750
Compare
This functionality is now merged in nf-core/tools (nf-core/tools#2362) so we can remove this.
This PR adds a new subcommand to generate a nf-params.yml template.
Sometimes it is easier to manually edit a parameter file than to use the web interface or interactive commandline wizard
provided by
nf-core launch
, for example when running a pipeline with many options on a remote server without a graphical interface.This command takes one argument - either the name of a nf-core pipeline which will be pulled automatically,
or the path to a directory containing a Nextflow pipeline (can be any pipeline, doesn't have to be nf-core).
The generated YAML file contains all parameters set to the pipeline default value along with their description in comments.
This template can then be used by uncommenting and modifying the value of parameters you want to pass to a pipline run.
First lines for eg rnaseq
Command help
I am not 100% convinced about the
params-template
name, since the template part may be easy to confuse with with the pipeline template.Maybe
nf-core params-file
is a better option?PR checklist
CHANGELOG.md
is updateddocs
is updated