Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore ignored config variables #2507

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Ignore ignored config variables #2507

merged 5 commits into from
Dec 1, 2023

Conversation

rernst
Copy link
Contributor

@rernst rernst commented Nov 9, 2023 •
edited
Loading

Skip timeline.enabled, report.enabled, trace.enabled and dag.enabled if they are configured as ignorable. Currently nf-core lint does not take this setting into account for these variables. I don't think any test or documentation changes are required.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@rernst rernst marked this pull request as ready for review November 9, 2023 12:27
mirpedrol
mirpedrol approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
rernst and others added 3 commits November 13, 2023 20:05
@rernst rernst merged commit a91d411 into nf-core:dev Dec 1, 2023
18 of 20 checks passed
@rernst rernst deleted the dev branch December 1, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rernst @mirpedrol