Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Path objects for ComponentCreate #2551

Merged
merged 8 commits into from
Dec 11, 2023
Merged

Use Path objects for ComponentCreate #2551

merged 8 commits into from
Dec 11, 2023

Conversation

mirpedrol
Copy link
Member

Follow up from #2549

  • Replace the library os by pathlib in ComponentCreate
  • Update modules and subworkflows template folder structure

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@mirpedrol mirpedrol mentioned this pull request Dec 1, 2023
Merged
4 tasks
mashehu
mashehu approved these changes Dec 11, 2023
View reviewed changes
nf_core/components/create.py Show resolved Hide resolved
nf_core/components/create.py Show resolved Hide resolved
nf_core/components/create.py Show resolved Hide resolved
nf_core/components/create.py Show resolved Hide resolved
nf_core/components/create.py Show resolved Hide resolved
nf_core/components/create.py Show resolved Hide resolved
nf_core/components/create.py Show resolved Hide resolved
nf_core/components/create.py Show resolved Hide resolved
@mirpedrol mirpedrol merged commit e860dc8 into nf-core:dev Dec 11, 2023
18 of 19 checks passed
@mirpedrol mirpedrol deleted the create-paths branch December 11, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirpedrol @mashehu