Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin dependencies #2806

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Unpin dependencies #2806

merged 3 commits into from
Feb 29, 2024

Conversation

FriederikeHanssen
Copy link
Contributor

Renovate is doing some weird pinning. This cause the Tower API version 1.9.0 on several pipelines to be installed instead >2.x:
https://nfcore.slack.com/archives/CTY8L26C8/p1709126514228189

I unpinned it again. But longterm it would be good to prevent renovate from doing this in the first place.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.40%. Comparing base (145fa48) to head (c6bc426).
Report is 22 commits behind head on dev.

❗ Current head c6bc426 differs from pull request most recent head 3725453. Consider uploading reports for the commit 3725453 to get more accurate results

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mashehu
Copy link
Contributor

mashehu commented Feb 28, 2024

this is now pinned to v2, so fine in my opinion. Feel free to reopen if I am wrong.

@mashehu mashehu closed this Feb 28, 2024
@FriederikeHanssen
Copy link
Contributor Author

? This pinning made all the pipelines fail: seqeralabs/action-tower-launch@aa88624706d400097880b69f1204f7f25436e93f

@mashehu
Copy link
Contributor

mashehu commented Feb 29, 2024

okay, you were right, we shouldn't use digests for our own actions for now. nf-core/ops#35 will fix this also in renovate

@mashehu mashehu reopened this Feb 29, 2024
@mashehu mashehu merged commit 2280e76 into nf-core:dev Feb 29, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants