Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version check in snapshot file #2888

Merged
merged 17 commits into from
Apr 5, 2024
Merged

Add version check in snapshot file #2888

merged 17 commits into from
Apr 5, 2024

Conversation

Joon-Klaps
Copy link
Contributor

@Joon-Klaps Joon-Klaps commented Mar 20, 2024 •
edited
Loading

PR checklist

Solves #2814

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

mashehu
mashehu requested changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also write a test where it is failing.

Joon-Klaps
Joon-Klaps commented Mar 21, 2024
View reviewed changes
nf_core/subworkflows/lint/subworkflow_tests.py Outdated
@@ -114,6 +114,22 @@ def subworkflow_tests(_, subworkflow: NFCoreComponent):
snap_file,
)
)
if "versions" in str(snap_content[test_name]) or "versions" in str(snap_content.keys()):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test I wrote for subworkflows, doesn't seem to even get to this part of the code and I'm not sure why.

@codecov Codecov
Copy link

codecov bot commented Apr 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.28%. Comparing base (20c1ea5) to head (53c7cda).
Report is 10 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Joon-Klaps Joon-Klaps merged commit c81f468 into nf-core:dev Apr 5, 2024
35 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joon-Klaps @mashehu