Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add organization to main.nf.test tag instead of using nfcore #3005

Merged
merged 4 commits into from
May 28, 2024

Conversation

nvnieuwk
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Fixes #2979

In custom modules repositories, the main.nf.test file contains the modules_nfcore tag (which doesn't really make sense). This PR updates this by doing the following steps:

  1. Update nf-core modules create and nf-core subworkflows create to add the modules_<organization tag instead of the modules_nfcore tag
  2. Update nf-core modules lint to make sure it passes the linting check

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.11%. Comparing base (b06712a) to head (a4ecb70).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nvnieuwk nvnieuwk added template nf-core pipeline/component template modules Related to tools for working with DSL2 modules enhancement subworkflows labels May 27, 2024
@nvnieuwk
Copy link
Contributor Author

Thanks for the reviews!

@nvnieuwk nvnieuwk merged commit d0b7594 into nf-core:dev May 28, 2024
36 checks passed
@nvnieuwk nvnieuwk deleted the add-org-to-tag branch May 28, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement modules Related to tools for working with DSL2 modules subworkflows template nf-core pipeline/component template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants