Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly parse the names form manifest.contributors #3364

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Properly parse the names form manifest.contributors #3364

merged 2 commits into from
Dec 20, 2024

Conversation

mirpedrol
Copy link
Member

Close #3361

@mirpedrol mirpedrol requested a review from mashehu December 17, 2024 14:53
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.97%. Comparing base (728a91c) to head (5ecf583).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/pipelines/rocrate.py 80.00% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirpedrol mirpedrol force-pushed the fix-3361-rocrate-contributors branch from cf43911 to 5ecf583 Compare December 17, 2024 15:09
@mirpedrol mirpedrol enabled auto-merge December 17, 2024 15:55
@ewels ewels added this to the 3.1.1 milestone Dec 19, 2024
JoseEspinosa
JoseEspinosa approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mirpedrol mirpedrol merged commit fe5c5ac into nf-core:dev Dec 20, 2024
88 checks passed
@mirpedrol mirpedrol deleted the fix-3361-rocrate-contributors branch December 20, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

@mashehu mashehu Awaiting requested review from mashehu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mirpedrol @JoseEspinosa @ewels