Do not use pre-release PyInquirer #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mashehu
approved these changes
Jul 21, 2020
Codecov Report
@@ Coverage Diff @@
## dev #684 +/- ##
==========================================
- Coverage 81.77% 81.41% -0.36%
==========================================
Files 13 13
Lines 2688 2696 +8
==========================================
- Hits 2198 2195 -3
- Misses 490 501 +11
Continue to review full report at Codecov.
|
apeltzer
approved these changes
Jul 23, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the pre-release functionality from PyInquirer so that we don't have to wait for v1.0.3. Reverts to stable 1.0.2 version for now.
Tested with the latest version of
mastercode for PyInquirer and this breaks, as they have merged in some fairly major structural changes. So I've pinnedPyInquirer==1.0.2for now.This will hopefully be stable enough for a release of tools. Can look into switching to Questionary / another tool at a later date still. I'm not writing that out.
Sidenote: I tested Questionary and the switch was easy, but it has the same two problems that PyInquirer has, yet without any fixes in the pipeline.