-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lint test for merge markers #861
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #861 +/- ##
==========================================
- Coverage 73.20% 71.73% -1.47%
==========================================
Files 22 30 +8
Lines 2784 3386 +602
==========================================
+ Hits 2038 2429 +391
- Misses 746 957 +211
Continue to review full report at Codecov.
|
Accidentally made this PR against master (again 🤦 ) that's why the branch protection failed.... |
Hmm strange - the comment still seemed to reference the wrong repo name, which should have been fixed in #860 |
Ah wait, the PR is against |
Okay good was already wondering why the tests still fail after running again 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should trigger a failure, not just a warning (so that it blocks PR merges).
Also suggested adding a pass if there are no problems found.
Haven't actually tried running the code yet but it looks fine to me 👍🏻
Co-authored-by: Phil Ewels <phil.ewels@scilifelab.se>
Hi guys, just letting you know that the test fails on merge_markers: Merge marker '<<<<<<<' in ./docs/images/output/DESeq2_QC/circRNA/DESeq2_dispersion.png: �4¨W¯^Ú\Oqqñ�#G.]º���������SXXhiiùl³<<<<<<<== #Gܸq#))éÑ£GÅÅŦ¦¦666666¯¿þºWïÞ½ÍÍÍ�[YtA… │ grep -R "<<<<<<<" docs/images/
Binary file docs/images/output/DESeq2_QC/circRNA/DESeq2_dispersion.png matches |
Thanks! Didn't see that one coming ... @ewels maybe omit anything that ends with |
PR checklist
CHANGELOG.md
is updateddocs
is updatedAdds a lint test looking for merge markers.
Closes #321