ios ISO15693 extended read/write commands (0x30 and 0x31) #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiegec
requested changes
Oct 5, 2023
| @@ -159,6 +159,26 @@ public class SwiftFlutterNfcKitPlugin: NSObject, FlutterPlugin, NFCTagReaderSess | |||
| } else { | |||
| result(FlutterError(code: "406", message: "No tag polled", details: nil)) | |||
| } | |||
| } else if call.method == "Iso15693extendedReadSingleBlock" { | |||
| // var nfcvTag: NFCISO15693Tag? | |||
There was a problem hiding this comment.
Please remove unused code comments.
README.md
Outdated
| dataBlock: [0x06, 0x16, 0x00, 0x00], | ||
| ); | ||
|
|
||
| // transceive is15693 0x30 command |
| @@ -379,6 +399,70 @@ public class SwiftFlutterNfcKitPlugin: NSObject, FlutterPlugin, NFCTagReaderSess | |||
| tag = nil | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
| @available(iOS 13.0, *) | |||
| ///Users/yuriy/dev/flutter_nfc_kit/ios/Classes/SwiftFlutterNfcKitPlugin.swift:428:23 | ||
|
|
||
|
|
||
| @available(iOS 13.0, *) |
There was a problem hiding this comment.
What will happen if it is not available?
| result(dataBlock) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
What if tag is not iso15693?
lib/flutter_nfc_kit.dart
Outdated
| @@ -344,7 +376,7 @@ class FlutterNfcKit { | |||
| } | |||
|
|
|||
| /// iOS only, change currently displayed NFC reader session alert message with [message]. | |||
| /// | |||
| /// | |||
There was a problem hiding this comment.
If you want to format code, please move these changes to a separate pull request.
|
@engeen Would you mind refining your code according to the reviewer's comments? Then I will be happy to merge your code. |
|
Hi, Shengqi. Yeah, There were really good comments and I hope I will find a
time to make a good contribution. But theres a lot of work, so still on
hold.
Вс, 29 окт. 2023 г. в 22:23, Shengqi Chen ***@***.***>:
… @engeen <https://github.com/engeen> Would you mind refining your code
according to the reviewer's comments? Then I will be happy to merge your
code.
—
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFYWXI23L6QCOXYPRCTTLYBZRF7AVCNFSM6AAAAAA5S33AW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGEZDQMRQGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ios ISO15693 extended read/write commands (0x30 and 0x31)
ios 13.0 only available