feat: implement dedicated handler thread for IO operations #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knthm
force-pushed
the
implement-dedicated-handler-thread
branch
from
2dbab25
to
13cd176
Compare
Harry-Chen
reviewed
May 29, 2024
android/src/main/kotlin/im/nfc/flutter_nfc_kit/FlutterNfcKitPlugin.kt
Outdated
Show resolved
Hide resolved
This prevents accidental simultaneous calls to the Android NFC methods, as well as performing better due to the lack of overhead from spawning new threads on each call.
knthm
force-pushed
the
implement-dedicated-handler-thread
branch
from
13cd176
to
829d0ea
Compare
|
Many thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a new thread would be spawned for each IO operation, this would in some cases lead to race conditions as IO operations could overlap.This prevents accidental simultaneous calls to the Android NFC methods, as well as performing better due to the lack of overhead from spawning new threads on each call.