Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library rework #24

Merged
merged 16 commits into from
Jul 27, 2023
Merged

Library rework #24

merged 16 commits into from
Jul 27, 2023

Conversation

kMutagene
Copy link
Member

This PR will eventually:

  • remove all js stuff (we do not plan to make this a core tool and therefore it does not need to be transpiled)
  • remove containerization of ISA tokens (meaining we only return a flat list of tokens with the base parser, see Unravel tokenization #20)
  • add more meaningful tests
  • clean up project structure

closes #20
closes #21
closes #23

@kMutagene
Copy link
Member Author

WIP pr to run ci on commits, do not merge.

@kMutagene
Copy link
Member Author

kMutagene commented Jul 27, 2023 •
edited
Loading

I think this is ready to be merged so we can start targeting this with new feature branches

@omaus

@kMutagene kMutagene marked this pull request as ready for review July 27, 2023 10:06
@kMutagene kMutagene requested a review from omaus July 27, 2023 10:07
@kMutagene kMutagene merged commit 3a0f1a7 into main Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omaus omaus omaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check how missing values are handled Add integration tests Unravel tokenization
2 participants
@kMutagene @omaus