Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template spreadsheet parsers #201

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Template spreadsheet parsers #201

merged 4 commits into from
Sep 21, 2023

Conversation

HLWeil
Copy link
Member

@HLWeil HLWeil commented Sep 21, 2023

  • Added spreadsheet file parsing capabilities
  • Changed keys, but included backwards compatability
  • Tests

Copy link
Collaborator

@Freymaurer Freymaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good stuff!



let fromParts (templateInfo:TemplateInfo) (ers:OntologyAnnotation list) (tags: OntologyAnnotation list) (authors : Person list) (table : ArcTable) (lastUpdated : System.DateTime)=
Template.make
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to use make, as this avoids issues with optional parameters.

@HLWeil HLWeil merged commit 437c17f into developer Sep 21, 2023
@Freymaurer Freymaurer deleted the developer_templates branch September 21, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants