support validation_packages_yml (continued)
#409
Conversation
kMutagene
changed the title
validation_packages_yml (continued)validation_packages_yml (continued)
|
@Freymaurer finally done adding all those tests 🥇 |
kMutagene
force-pushed
the
validation-packages
branch
from
3905a62 to
ba8d69e
Compare
| @@ -22,6 +22,15 @@ type ValidationPackage(name, ?version) = | |||
| member this.Copy() = | |||
| ValidationPackage.make this.Name this.Version | |||
|
|
|||
| /// Pretty printer | |||
| override this.ToString() = | |||
There was a problem hiding this comment.
Maybe do not use yaml style for pretty printing, or use YAMLicious to generate this. But i would prefer typical f# printing syntax
There was a problem hiding this comment.
If this is just taste, i would prefer keeping it as many tests would need to be adapted
There was a problem hiding this comment.
Also, i think the to string is valuable here because it represents something that only ever exists as a yaml file in the arc.
There was a problem hiding this comment.
It is just that the ToString function should not be responsible for YAML formatting, this should be a different function.
There was a problem hiding this comment.
it is not. it is just for printing. formatting for actual yaml export is done with yamlicious.
There was a problem hiding this comment.
Then why do we have tests for this? 😮
There was a problem hiding this comment.
i just tested everything that i added
| | :? ValidationPackagesConfig as other_vpc -> other_vpc.ValidationPackages = this.ValidationPackages && other_vpc.ARCSpecification = this.ARCSpecification | ||
|
|
||
| /// Pretty printer | ||
| override this.ToString() = |
There was a problem hiding this comment.
Same as ValidationPackage.ToString()
kMutagene
force-pushed
the
validation-packages
branch
from
d0ae4d0 to
8de0653
Compare
…config file, add related tests
This PR continues #403 :