Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: CSV fragment selector indices should be 1-based and count headers #529

Closed
HLWeil opened this issue Oct 7, 2024 · 3 comments
Closed

[Bug]: CSV fragment selector indices should be 1-based and count headers #529

HLWeil opened this issue Oct 7, 2024 · 3 comments
Assignees
@Freymaurer
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@HLWeil
Copy link
Member

HLWeil commented Oct 7, 2024

Contact Details

No response

What happened?

Data fragment indices created by Data Annotator tool should be 1-based and headers should ne be ignored. See rfc-7111

So in the given example:

image

I selected the first non-header row, which is the second row of the file.

Therefore the correct fragment selector would be row=2 but is:

image

What did you expect?

No response

Host

Applies to All

Host Details

Windows11
https://swate-alpha.nfdi4plants.org/

Swate version

?
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Oct 7, 2024
Freymaurer added a commit that referenced this issue Oct 7, 2024
@Freymaurer
Fix wrong csv row selector format #529 🐛
b0619b3
@Freymaurer
Copy link
Collaborator

Done! Should be live soon!

@github-project-automation github-project-automation bot moved this to Done in ARCStack Oct 7, 2024
@HLWeil HLWeil reopened this Oct 7, 2024
@HLWeil
Copy link
Member Author

HLWeil commented Oct 7, 2024

Thanks a lot for your timely fix!

Just noticed that selectors for Colulms are 0-based. They should also be one-based. And the same is true for the cells.

image

@Freymaurer Freymaurer self-assigned this Oct 8, 2024
@Freymaurer Freymaurer added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed Status: Needs Triage This item is up for investigation. labels Oct 8, 2024
@Freymaurer Freymaurer moved this from Done to Backlog in ARCStack Oct 8, 2024
@Freymaurer
Copy link
Collaborator

Fixed! Very sorry about the oversight, was very stressful yesterday

@github-project-automation github-project-automation bot moved this from Backlog to Done in ARCStack Oct 9, 2024
Freymaurer added a commit that referenced this issue Oct 9, 2024
@Freymaurer
fix column and cell indexing for data annotation #529
5131b86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Freymaurer Freymaurer

Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
ARCStack
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HLWeil @Freymaurer