Feature: Excel, enable export of metadata as json #540
Conversation
| /// </summary> | ||
| let validateAnnotationTable context = | ||
| let validateAnnotationTable excelTable context = |
There was a problem hiding this comment.
unify with validateExcelTable. Keep only one
There was a problem hiding this comment.
I renamed the method because we have to keep it. It is used by another function, that checks whether the selected building block is valid or not.
| @@ -1982,7 +1979,8 @@ let validateAnnotationTable context = | |||
| let rectifyTermColumns () = | |||
| Excel.run(fun context -> | |||
| promise { | |||
| let! result = validateAnnotationTable context | |||
| let! excelTable = getActiveAnnotationTable context | |||
| let! result = validateAnnotationTable excelTable context | |||
There was a problem hiding this comment.
integrate validation into getArcTable-like function
| let mainColumn = | ||
| if snd buildingBlock.[1] = "Unit" then | ||
| if buildingBlock.Length > 1 && snd buildingBlock.[1] = "Unit" then |
There was a problem hiding this comment.
ensure correct table read in readTable-like function. There should be no syntax adaption/validation outside of getTable.
| let mutable errors = List.empty | ||
|
|
||
| for i in 0 .. annotationTables.Length-1 do | ||
| let! potErrors = validateAnnotationTable annotationTables.[i] context |
There was a problem hiding this comment.
see as above, should be part of getTable-like function
| ) | ||
| ) | ||
|
|
||
| let inMemoryTables = Array.init annotationTables.Length (fun _ -> None) |
There was a problem hiding this comment.
if you want to keep this mutable, use ResizeArray.
| ) | ||
|
|
||
| let inMemoryTables = Array.init annotationTables.Length (fun _ -> None) | ||
| let mutable errors = List.empty |
There was a problem hiding this comment.
if you want to keep this mutable use ResizeArray
| inMemoryTables | ||
| |> Array.choose (fun x -> x) | ||
|
|
||
| return (results, errors) |
There was a problem hiding this comment.
Use Result.Ok of results and Result.Error of errors
Closes #451