Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to between kebab-case and snake_case #236

Closed
wants to merge 1 commit into from

Conversation

pgjones
Copy link

@pgjones pgjones commented Jan 3, 2022

Status

READY

Description

This can then be combined with the other functions to convert
kebab-case to any other supported case.

Note the character casing is preserved in conversion as I think this
makes the most sense. It can trivially be altered after using lower or
upper.

Related Issues

Fixes #218 and #180

Todos

  • Tests
  • Documentation

@ronnie-llamado
Copy link
Contributor

@pgjones Can you rebase this PR when you get the chance? I anticipate it will pass; the workflow was just updated (#237).

This can then be combined with the other functions to convert
kebab-case to any other supported case.

Note the character casing is preserved in conversion as I think this
makes the most sense. It can trivially be altered after using lower or
upper.
@pgjones
Copy link
Author

pgjones commented Jan 3, 2022

@ronnie-llamado I've just updated, thanks.

@coveralls
Copy link

coveralls commented Jan 3, 2022

Pull Request Test Coverage Report for Build 1651221274

  • 15 of 18 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.0%) to 96.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
humps/main.py 15 18 83.33%
Totals Coverage Status
Change from base Build 1650441096: -4.0%
Covered Lines: 72
Relevant Lines: 75

💛 - Coveralls

@nficano
Copy link
Owner

nficano commented Oct 21, 2022

Can you please fix the coverage decrease?

@pgjones
Copy link
Author

pgjones commented Oct 23, 2022

It looks like @grehnj took these changes and created #272 which was then merged. Will close.

@pgjones pgjones closed this Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Kebab case?
4 participants