Don't overwrite passer, rusher, receiver on abnormal plays with penalties

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: nflfastR
 Title: Functions to Efficiently Access NFL Play by Play Data
-Version: 4.5.1.9013
+Version: 4.5.1.9014
 Authors@R: 
     c(person(given = "Sebastian",
              family = "Carl",

NEWS.md

@@ -15,6 +15,7 @@
 - Drop the pseudo plays TV Timeout and Two-Minute Warning. (#426)
 - Fix posteam on kickoffs and PATs following a defensive TD in 2023+ pbp. (#427)
 - `calculate_player_stats()` no more counts lost fumbles on plays where a player fumbles, a team mate recovers and then loses a fumble to the defense. (#431)
+- The variables `passer`, `receiver`, and `rusher` no more return `NA` on "abnormal" plays - like direct snaps, aborted snaps, laterals etc. - that resulted in a penalty. (#435) 
 
 # nflfastR 4.5.1
 

R/helper_additional_functions.R

@@ -78,15 +78,15 @@ clean_pbp <- function(pbp, ...) {
         receiver_jersey_number = stringr::str_extract(stringr::str_extract(.data$desc, glue::glue('{receiver_number}{big_parser}')), "[:digit:]*") %>% as.integer(),
         #overwrite all these weird plays messing with the parser
         receiver = dplyr::case_when(
-          stringr::str_detect(.data$desc, glue::glue('{abnormal_play}')) ~ .data$receiver_player_name,
+          stringr::str_detect(.data$desc, glue::glue('{abnormal_play}')) & !is.na(.data$receiver_player_name) ~ .data$receiver_player_name,
           TRUE ~ .data$receiver
         ),
         rusher = dplyr::case_when(
-          stringr::str_detect(.data$desc, glue::glue('{abnormal_play}')) ~ .data$rusher_player_name,
+          stringr::str_detect(.data$desc, glue::glue('{abnormal_play}')) & !is.na(.data$rusher_player_name) ~ .data$rusher_player_name,
           TRUE ~ .data$rusher
         ),
         passer = dplyr::case_when(
-          stringr::str_detect(.data$desc, glue::glue('{abnormal_play}')) ~ .data$passer_player_name,
+          stringr::str_detect(.data$desc, glue::glue('{abnormal_play}')) & !is.na(.data$passer_player_name) ~ .data$passer_player_name,
           TRUE ~ .data$passer
         ),
         # fix the plays where scramble was fixed using charting data in 2005