Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to signals #1883

Merged
merged 6 commits into from
Jan 29, 2025
Merged

refactor: migrate to signals #1883

merged 6 commits into from
Jan 29, 2025

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jan 19, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@cipchk
Copy link
Member Author

cipchk commented Jan 19, 2025

Preview is ready!

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (a1c4fb1) to head (3eb7c0f).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1883    +/-   ##
========================================
  Coverage   94.96%   94.97%            
========================================
  Files         273      273            
  Lines        8862     8851    -11     
  Branches     1714     1814   +100     
========================================
- Hits         8416     8406    -10     
  Misses        366      366            
+ Partials       80       79     -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cipchk cipchk changed the title refactor(abc:error-collect): migrate to signals refactor: migrate to signals Jan 19, 2025
@cipchk cipchk merged commit f503c9f into master Jan 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant