-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datetimepicker): resolve issue with active cell highlighting #381
Changes from 1 commit
63a7c80
3fab6aa
e192ab6
fcda2d0
4f7368f
3651680
315a52f
cb12091
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,19 @@ | ||
<table class="mtx-calendar-table" role="grid"> | ||
<thead class="mtx-calendar-table-header"> | ||
<tr> | ||
@for (day of _weekdays; track day) { | ||
<th [attr.aria-label]="day.long">{{day.narrow}}</th> | ||
@for (day of _weekdays; track day.long) { | ||
<th [attr.aria-label]="day.long">{{day.narrow}}</th> | ||
} | ||
</tr> | ||
</thead> | ||
<tbody mtx-calendar-body | ||
<tbody | ||
mtx-calendar-body | ||
(@slideCalendar.done)="_calendarStateDone()" | ||
[@slideCalendar]="_calendarState" | ||
[rows]="_weeks" | ||
[todayValue]="_todayDate!" | ||
[activeCell]="_adapter.getDate(activeDate) - 1" | ||
[activeCell]="_getActiveCell()" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The active cell logic has no issue, we just should improve the a11y. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I figured it out! Material has implemented a11y very effectively. |
||
[selectedValue]="_selectedDate!" | ||
(selectedValueChange)="_dateSelected($event)"></tbody> | ||
(selectedValueChange)="_dateSelected($event)" | ||
></tbody> | ||
</table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new empty line