Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update rollup to ^0.55.0 #534

Merged
merged 1 commit into from
Feb 3, 2018
Merged

fix: update rollup to ^0.55.0 #534

merged 1 commit into from
Feb 3, 2018

Conversation

dherges
Copy link
Contributor

@dherges dherges commented Jan 24, 2018

I'm submitting a...

[x] Bug Fix
[ ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

Updates rollup.

Closes #488, #523

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@dherges dherges changed the title Fix update rollup fix: update rollup to ^0.55.0 Jan 24, 2018
@dherges
Copy link
Contributor Author

dherges commented Jan 24, 2018

Blocked by rollup/rollup#1902

@TravisBuddy
Copy link
Contributor

Travis tests have failed

Hey David,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

yarn test
yarn run v1.3.2
$ yarn build && yarn test:specs && yarn integration:samples && yarn integration:specs && yarn integration:consumers
$ rimraf dist && yarn schema
$ json2ts --input src/ng-package.schema.json --output src/ng-package.schema.ts
$ tsc -p src/tsconfig.packagr.json
node_modules/rollup/dist/typings/Graph.d.ts(1,22): error TS6053: File '/home/travis/build/dherges/ng-packagr/node_modules/rollup/src/Graph.d.ts' not found.
node_modules/rollup/dist/typings/watch/index.d.ts(2,8): error TS1192: Module '"events"' has no default export.
src/lib/flatten/rollup.ts(10,37): error TS2694: Namespace '"/home/travis/build/dherges/ng-packagr/node_modules/rollup/dist/typings/node-entry"' has no exported member 'Format'.
src/lib/flatten/rollup.ts(26,26): error TS2694: Namespace '"/home/travis/build/dherges/ng-packagr/node_modules/rollup/dist/typings/node-entry"' has no exported member 'Bundle'.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Node.js: 8

yarn test
yarn run v1.3.2
$ yarn build && yarn test:specs && yarn integration:samples && yarn integration:specs && yarn integration:consumers
$ rimraf dist && yarn schema
$ json2ts --input src/ng-package.schema.json --output src/ng-package.schema.ts
$ tsc -p src/tsconfig.packagr.json
node_modules/rollup/dist/typings/Graph.d.ts(1,22): error TS6053: File '/home/travis/build/dherges/ng-packagr/node_modules/rollup/src/Graph.d.ts' not found.
node_modules/rollup/dist/typings/watch/index.d.ts(2,8): error TS1192: Module '"events"' has no default export.
src/lib/flatten/rollup.ts(10,37): error TS2694: Namespace '"/home/travis/build/dherges/ng-packagr/node_modules/rollup/dist/typings/node-entry"' has no exported member 'Format'.
src/lib/flatten/rollup.ts(26,26): error TS2694: Namespace '"/home/travis/build/dherges/ng-packagr/node_modules/rollup/dist/typings/node-entry"' has no exported member 'Bundle'.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Node.js: 7

yarn test
yarn run v1.3.2
warning You are using Node "7.10.1" which is not supported and may encounter bugs or unexpected behavior. Yarn supports the following semver range: "^4.8.0 || ^5.7.0 || ^6.2.2 || >=8.0.0"
$ yarn build && yarn test:specs && yarn integration:samples && yarn integration:specs && yarn integration:consumers
warning You are using Node "7.10.1" which is not supported and may encounter bugs or unexpected behavior. Yarn supports the following semver range: "^4.8.0 || ^5.7.0 || ^6.2.2 || >=8.0.0"
$ rimraf dist && yarn schema
warning You are using Node "7.10.1" which is not supported and may encounter bugs or unexpected behavior. Yarn supports the following semver range: "^4.8.0 || ^5.7.0 || ^6.2.2 || >=8.0.0"
$ json2ts --input src/ng-package.schema.json --output src/ng-package.schema.ts
$ tsc -p src/tsconfig.packagr.json
node_modules/rollup/dist/typings/Graph.d.ts(1,22): error TS6053: File '/home/travis/build/dherges/ng-packagr/node_modules/rollup/src/Graph.d.ts' not found.
node_modules/rollup/dist/typings/watch/index.d.ts(2,8): error TS1192: Module '"events"' has no default export.
src/lib/flatten/rollup.ts(10,37): error TS2694: Namespace '"/home/travis/build/dherges/ng-packagr/node_modules/rollup/dist/typings/node-entry"' has no exported member 'Format'.
src/lib/flatten/rollup.ts(26,26): error TS2694: Namespace '"/home/travis/build/dherges/ng-packagr/node_modules/rollup/dist/typings/node-entry"' has no exported member 'Bundle'.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Node.js: 6

yarn test
yarn run v1.3.2
$ yarn build && yarn test:specs && yarn integration:samples && yarn integration:specs && yarn integration:consumers
$ rimraf dist && yarn schema
$ json2ts --input src/ng-package.schema.json --output src/ng-package.schema.ts
$ tsc -p src/tsconfig.packagr.json
node_modules/rollup/dist/typings/Graph.d.ts(1,22): error TS6053: File '/home/travis/build/dherges/ng-packagr/node_modules/rollup/src/Graph.d.ts' not found.
node_modules/rollup/dist/typings/watch/index.d.ts(2,8): error TS1192: Module '"events"' has no default export.
src/lib/flatten/rollup.ts(10,37): error TS2694: Namespace '"/home/travis/build/dherges/ng-packagr/node_modules/rollup/dist/typings/node-entry"' has no exported member 'Format'.
src/lib/flatten/rollup.ts(26,26): error TS2694: Namespace '"/home/travis/build/dherges/ng-packagr/node_modules/rollup/dist/typings/node-entry"' has no exported member 'Bundle'.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@unstubbable
Copy link

I'm just here to say hello. 👋😊

@dherges
Copy link
Contributor Author

dherges commented Jan 26, 2018

Der Henne!

https://www.youtube.com/watch?v=boTz2IKpbWY

😄

@dherges dherges merged commit 0cb0cce into master Feb 3, 2018
@dherges dherges deleted the fix-update-rollup branch February 3, 2018 08:22
@github-actions
Copy link

This PR has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

This action has been performed automatically by a bot.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants