Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for https://github.com/sass/node-sass/issues/337 #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tony-kerz
Copy link
Contributor

i was getting the following until i followed some hints in this thread: sass/node-sass#337

warlock-scratch-2 $ warlock

Starting tasks: default
Starting task: flow::templates-to-build
Starting task: flow::coffee-to-build
Starting task: flow::sass-to-build
Starting task: flow::assets-to-build
Starting task: clean::styles-to-build
Starting task: flow::vendor-styles-to-build
[vendor-styles-to-build] Got empty globbing pattern. Skipping flow.
Starting task: flow::styles-to-build
Starting task: clean::scripts-to-build
Starting task: flow::vendor-scripts-to-build
Starting task: flow::scripts-to-build
Starting task: clean::html-to-build
Starting task: clean::scripts-to-compile
Starting task: flow::assets-to-compile
Starting task: clean::styles-to-compile
Starting task: clean::html-to-compile
Assertion failed: (val->IsString()), function _NanGetExternalParts, file ../node_modules/nan/nan.h, line 1725.
Abort trap: 6

workaround for issue with latest version of node-sass, see:

sass/node-sass#337
@joshdmiller
Copy link
Member

With ngbp, a lot of people requested source maps. I quickly perused the issue you mentioned, and there was a lot going on. To help me understand a little bit better, is this an upstream bug?

@tony-kerz
Copy link
Contributor Author

yeah, source maps are def a goal, and yeah, this looks like what i'm sure will be a transient issue with an upstream dependency. so depending on upstream fix versions, it may just resolve itself with the chain: gulp-sass (~0.7) -> node-sass (^0.9) -> nan (~1.2.0).

as i think you are alluding to, it may not make sense to incorporate this pull to accommodate a transient situation upstream, but i figured i would just post it in case someone was plagued by the issue and wanted to use it for a temporary workaround while upstream issues got sorted out. feel free to handle as you see fit while this situation exists.

regards,
tony.

@joshdmiller
Copy link
Member

as i think you are alluding to, it may not make sense to incorporate this pull to accommodate a transient situation upstream

You're right, with the exception that this is a default configuration option that is not required to function. I'm open to making the change, I just want to understand what's going on a little better.

Under what circumstances will this error occur?

@tony-kerz
Copy link
Contributor Author

nothing too fancy as i'm kind of a novice, pretty sure i just:

and ran warlock

@joshdmiller
Copy link
Member

Alright, sold. :-)

Landed as 3c33977.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants