This repository has been archived by the owner on Nov 17, 2020. It is now read-only.
Fix syntax error and fix styleguide compliance #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Personally I no longer use puppet and switched to use salt. But if you want to improve puppet-x2go I am willing to put a notice on github or puppet hub to direct newcomers to your site. I think there is no other way to pass a puppet module to another leader. |
|
A notice on Puppetforge would be helpful. You could also delete the module in the forge and just keep the repo in GitHub so user would only find the active x2go module(s). The fork is now active as fischassetmanagement/x2go. |
Fix wrong PGP key and change apt repo syntax. Change metadata. Add stdlib as requirement and increase version to 0.3.1, require puppetlabs-apt >= 2.0.0 Update version to 0.3.3. puppetlabs/apt: By default, Puppet runs apt-get update on the first Puppet run after you include the apt class, and anytime notify => Exec['apt_update']
kallies
commented
Nov 28, 2017
| @@ -4,12 +4,13 @@ | |||
| # under the terms of the GNU General Public License version 3 as published by | |||
| # the Free Software Foundation.class | |||
| class x2go::client ( | |||
| $ensure = false, | |||
| $ensure = 'present', | |||
| $install_client = ::x2go::install_client, | |||
| @@ -4,28 +4,12 @@ | |||
| # under the terms of the GNU General Public License version 3 as published by | |||
| # the Free Software Foundation | |||
| class x2go::server ( | |||
| $ensure = false, | |||
| $ensure = 'present', | |||
| $install_server = ::x2go::install_server, | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed some styleguide compliance issues reported by puppet-lint. The Require syntax issue is fixed, too.