Make sure file generated by docker-gen has the right permissions #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue is still open, right? |
|
I'm going to close then re-open this PR to trigger the tests. |
|
Ack, crap, I forgot this repo was still using Travis CI. |
|
Merged in #352 |
|
Thanks!!! |
|
If you have other Issues / PR of interest in mind don't hesitate to tag me, I've been mostly focusing my efforts on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the destination file does not exists, the permissions become
600because this is the default permission for temp files.This is problematic, if the container consuming the destination file does not run as root.
Instead, the default permissions should be used (as per umask).
This PR will make permission
644, which is generally what we want. And if the container consuming it is not happy with it, it always can override the permissions.