Support cgroup docker_limit.slice memory and cpu limits for docker daemon #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickelindahl
changed the title
mickelindahl
changed the title
mickelindahl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to restrict the total resources that the docker daemon can utilize on a server. The solution inlcuded adding a docker_limit.slice file to /etc/systemd/system (see https://github.com/mickelindahl/docker_daemon_limit_total_resources). This results in that in "/proc/self/cgroup" containers are named .../docker_limit.slice/{container id}. Thus matchDockerCurrentContainerID nor matchECSCurrentContainerID could pick up the container name which left me with a broken nginx-proxy. I have added an additional funcition matchDockerLimitCurrentContainerID witch solves this problem. Would love if you could add this to the project.
Cheers
/Mikael