Fix exit(2) on SIGHUP before fully initialized. #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI @JoelLinn, thanks for catching and fixing this one. Have you been able to test the fix in production ? Edit: looking at the issue seems like yes, you and others did. |
|
I have deployed this fix (as my custom build on-top the master tip of that time) over a year ago on about 40 servers and didn’t have any (re-)generation problems since then. It seems to be the root cause for the issue #244 (although the issue title is pretty generic so there might be all sorts of causes for a phenomenon like it) I’m happy this project is maintained again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-gen uses SIGHUP to trigger regeneration.
However, when SIGHUP is fired before docker-gen is fully initialized (and the signal handler was installed), the process will just exit(2).
This fix ignores SIGHUP until the signal handler is installed.
Fixes #244